Use alternate form flag (#) to disable overflow with ellipsis#707
Merged
bluss merged 3 commits intorust-ndarray:masterfrom Sep 15, 2019
Merged
Use alternate form flag (#) to disable overflow with ellipsis#707bluss merged 3 commits intorust-ndarray:masterfrom
bluss merged 3 commits intorust-ndarray:masterfrom
Conversation
jturner314
force-pushed
the
alt-form-format
branch
from
33123c0 to
fe54105
Compare
bluss
approved these changes
Sep 12, 2019
Member
|
Thanks! |
bluss
approved these changes
Sep 15, 2019
Member
bluss
left a comment
bluss
left a comment
There was a problem hiding this comment.
This is a nice refactoring, so let's merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to print all the elements of an array if one of the axis lengths exceeds the limit before overflowing with an ellipsis. This PR makes it so that if the alternate form flag (
#) is specified, the axis length limit is disabled. It also simplifies the array formatting implementation.Fixes #705.